Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure there’s a placeholder for offline newly added products until it’s possible to fetch them from the network #2459

Closed
2 tasks
teolemon opened this issue Jun 30, 2022 · 0 comments · Fixed by #2433
Closed
2 tasks

Ensure there’s a placeholder for offline newly added products until it’s possible to fetch them from the network #2459

teolemon opened this issue Jun 30, 2022 · 0 comments · Fixed by #2433
Assignees
@AshAman999
Labels
Offline - Contribution Offline Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. product scan carousel
Milestone
Offline contribution

Comments

@teolemon
Copy link
Member

teolemon commented Jun 30, 2022 •
edited
Loading

What

  • Ensure there’s a placeholder for offline newly added products until it’s possible to fetch them from the network
  • The placeholder should have a Try reloading button

Part of
@teolemon teolemon added Offline - Contribution Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. Offline product scan carousel labels Jun 30, 2022
@teolemon teolemon added this to the Offline contribution milestone Jul 4, 2022
@AshAman999 AshAman999 self-assigned this Jul 8, 2022
@AshAman999 AshAman999 mentioned this issue Jul 8, 2022
Merged
@teolemon teolemon linked a pull request Jul 20, 2022 that will close this issue
fix: Background image upload #2433
Merged
@teolemon teolemon moved this from To discuss and validate to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 16, 2022
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 1, 2022
Repository owner moved this from In Progress to Done in 📶 🤳 Offline scan/experience Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshAman999 AshAman999

Labels
Offline - Contribution Offline Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. product scan carousel
Projects
📶 🤳 Offline scan/experience
Archived in project
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Offline contribution
Development

Successfully merging a pull request may close this issue.

fix: Background image upload AshAman999/smooth-app
2 participants
@teolemon @AshAman999