Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better place holder when no internet connection #2560

Merged
merged 2 commits into from
Jul 9, 2022
Merged

fix: better place holder when no internet connection #2560

merged 2 commits into from
Jul 9, 2022

Conversation

AshAman999
Copy link
Member

What

  • Better place holder for no internet cases

Screenshot

Dark Mode
image

Light Mode
image

Fixes bug(s)

@AshAman999 AshAman999 requested a review from a team as a code owner July 8, 2022 19:19
@AshAman999 AshAman999 requested a review from teolemon July 8, 2022 19:22
@teolemon
Copy link
Member

teolemon commented Jul 9, 2022

thanks @AshAman999 @monsieurtanuki
☁️

@teolemon teolemon merged commit e4ea159 into openfoodfacts:develop Jul 9, 2022
@github-actions github-actions bot mentioned this pull request Jul 19, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@AshAman999 AshAman999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The offline icon placeholder in the image carousel is ugly and confusing
3 participants
@AshAman999 @teolemon @monsieurtanuki