Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure all text inputs have coherent cursors + heights #2578

Merged
merged 3 commits into from
Jul 12, 2022
Merged

fix: Ensure all text inputs have coherent cursors + heights #2578

merged 3 commits into from
Jul 12, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 11, 2022

All inputs that use a SmoothTextFormField have:

  • A different font size between the hint and the value
  • The cursor if often misaligned
  • onFieldSubmitted not available to sub widgets

This PR fixes all these issues

@g123k g123k added 🎨 UI / UX Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 👥 User management Account login, signup, signout labels Jul 11, 2022
@g123k g123k self-assigned this Jul 11, 2022
@g123k g123k requested a review from a team as a code owner July 11, 2022 09:30
@g123k g123k mentioned this pull request Jul 11, 2022
Closed
@g123k g123k changed the title Fix: Ensure all text inputs have coherent cursors + heights fix: Ensure all text inputs have coherent cursors + heights Jul 11, 2022
@teolemon teolemon merged commit 6ad23ae into openfoodfacts:develop Jul 12, 2022
@teolemon
Copy link
Member

thanks @g123k :-)

@github-actions github-actions bot mentioned this pull request Jul 19, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshAman999 AshAman999 AshAman999 approved these changes

Assignees

@g123k g123k

Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🎨 UI / UX 👥 User management Account login, signup, signout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g123k @teolemon @AshAman999