Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2647 - added a refresh gesture to edit product page #2649

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

monsieurtanuki
Copy link
Contributor

@monsieurtanuki monsieurtanuki commented Jul 23, 2022

Impacted file:

  • edit_product_page.dart: added a refresh gesture; refactored not creating a Scaffold variable anymore

What

  • Added a refresh gesture to edit product page.

Fixes bug(s)

Impacted file:
* `edit_product_page.dart`: added a refresh gesture; refactored putting not creating a `Scaffold` variable anymore
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner July 23, 2022 16:07
@codecov-commenter
Copy link

Codecov Report

Merging #2649 (2f262e8) into develop (2ea0da3) will decrease coverage by 1.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2649      +/-   ##
==========================================
- Coverage     8.86%   7.38%   -1.49%     
==========================================
  Files          161     215      +54     
  Lines         6623   10352    +3729     
==========================================
+ Hits           587     764     +177     
- Misses        6036    9588    +3552     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 24.65% <0.00%> (-6.78%) ⬇️
packages/smooth_app/lib/main.dart 14.16% <0.00%> (-3.73%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (-0.88%) ⬇️
... and 227 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@monsieurtanuki monsieurtanuki merged commit e163167 into openfoodfacts:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow slide down to refresh the product in edit mode
3 participants