fix: Login button whole width centre #2668

prathamsoni11 · 2022-07-27T15:30:58Z

What

Centred the login button as per issue Login button not in whole width center #2059 .

Screenshot

Fixes bug(s)

Part of

Login button not in whole width center #2059

AshAman999 · 2022-07-27T15:48:18Z

Few comments for you that might be helpful

I don't know why you create a pr then close it then open a new one, try to work on one, if you could revisit your git concepts
2nd the tests are failing, probably theme color, did you look into if the app still looks good in both light and dark mode
( probably button theme color)
You can test your code locally by running flutter test

prathamsoni11 · 2022-07-27T15:52:48Z

Few comments for you that might be helpful

I don't know why you create a pr then close it then open a new one, try to work on one, if you could revisit your git concepts

2nd the tests are failing, probably theme color, did you look into if the app still looks good in both light and dark mode
( probably button theme color)

You can test your code locally by running flutter test

Sorry for deleting PR actually my project was crashed and I was not able to commit so that's why I have to do that. There is git issue in Android Studio sometime it show there is no git and sometime it runs correctly so due to that I did this.

Ok let me check in every theme mode.

AshAman999 · 2022-07-27T18:40:36Z

Hey @prathamsoni11
Don't stress about the tests, probably not a problem by your side, I guess the tests need to updated here now

prathamsoni11 · 2022-07-28T04:27:41Z

Hey @prathamsoni11
Don't stress about the tests, probably not a problem by your side, I guess the tests need to updated here now

ok

AshAman999 · 2022-07-28T12:07:10Z

@monsieurtanuki
Can you have a look, if the golden tests needs to be updated here

monsieurtanuki · 2022-07-28T12:20:50Z

Can you have a look, if the golden tests needs to be updated here

@AshAman999 Not really. Just run flutter test --update-goldens - if there are file changes, then they need to be updated.

Btw @prathamsoni11 I'm still waiting for answers and for a screenshot on tablets.

prathamsoni11 · 2022-07-28T12:22:24Z

Can you have a look, if the golden tests needs to be updated here

@AshAman999 Not really. Just run flutter test --update-goldens - if there are file changes, then they need to be updated.

Btw @prathamsoni11 I'm still waiting for answers and for a screenshot on tablets.

Can I send the screenshot of web version?

monsieurtanuki · 2022-07-28T12:23:51Z

Can I send the screenshot of web version?

There's no web version.
Just use device_preview, on the bottom of your device/emulator.

prathamsoni11 · 2022-07-28T12:24:30Z

Can I send the screenshot of web version?

There's no web version. Just use device_preview, on the bottom of your device/emulator.

ok sending

prathamsoni11 · 2022-07-28T12:30:01Z

@monsieurtanuki

monsieurtanuki · 2022-07-28T12:48:35Z

@M123-dev Does the screenshot on tablet match your expectations?

M123-dev · 2022-07-28T13:30:21Z

Yes it's great that it's in center. Maybe we could put it as a trailing on big devices, but as the whole UI is aimed at mobile users we don't need to do that here

monsieurtanuki

@prathamsoni11 I'm afraid that your code works only on the main settings page. But not in the account settings page.

monsieurtanuki · 2022-07-27T15:35:41Z

packages/smooth_app/lib/pages/preferences/user_preferences_page.dart

+        if (type == PreferencePageType.ACCOUNT) {
+          children.add(
+            Container(
+              margin: const EdgeInsets.symmetric(horizontal: LARGE_SPACE * 7),


It's probably 6 rather than 7. Or 8, I don't know.
Or maybe a Center would do the trick, wouldn't it?

@prathamsoni11 ping

maybe 6 would be better

Forget about 6. For instance use something related to the screen width.

prathamsoni11 · 2022-07-28T13:45:11Z

@prathamsoni11 I'm afraid that your code works only on the main settings page. But not in the account settings page.

Sorry I cannot get the page you are referring about. Can you justify it more?

monsieurtanuki · 2022-07-28T13:54:23Z

Sorry I cannot get the page you are referring about. Can you justify it more?

I thought the button was used somewhere else. It's not, you're right, forget about that.

prathamsoni11 · 2022-07-28T13:57:02Z

@monsieurtanuki
Which one I should commit? I used screen width as reference.

monsieurtanuki · 2022-07-28T14:31:48Z

@prathamsoni11 For the record I have very little interest in UI in general, and both screenshots look good.
That said, it's safer to use a larger button - you never know how "sign in" is going to be localized - so the first screenshot.
I'm even surprised that you need to specify a width.

…1/smooth-app into login_button_center

prathamsoni11 · 2022-07-28T14:39:16Z

@prathamsoni11 For the record I have very little interest in UI in general, and both screenshots look good.
That said, it's safer to use a larger button - you never know how "sign in" is going to be localized - so the first screenshot.
I'm even surprised that you need to specify a width.

done with commit

monsieurtanuki · 2022-07-28T14:46:53Z

Just run flutter test --update-goldens - if there are file changes, then they need to be committed.

@prathamsoni11 ping

prathamsoni11 · 2022-07-28T14:50:14Z

flutter test --update-goldens

All test passed 👍🏻

monsieurtanuki · 2022-07-28T14:52:37Z

All test passed 👍🏻

Of course they did: those "tests" generate the screenshots we have to test against.
You (I mean the command) have generated files: please commit them.

prathamsoni11 · 2022-07-28T14:56:24Z

All test passed 👍🏻

Of course they did: those "tests" generate the screenshots we have to test against. You (I mean the command) have generated files: please commit them.

done

monsieurtanuki

Thank you @prathamsoni11!

Login button whole width center

44bb5c9

prathamsoni11 requested a review from a team as a code owner July 27, 2022 15:30

github-actions bot assigned prathamsoni11 Jul 27, 2022

Merge branch 'develop' into login_button_center

6053db5

Merge branch 'develop' into login_button_center

d2ef4c2

monsieurtanuki reviewed Jul 28, 2022

View reviewed changes

prathamsoni11 added 2 commits July 28, 2022 20:08

change of button width with respect of screen width

876d384

Merge branch 'login_button_center' of https://github.com/prathamsoni1…

05ec275

…1/smooth-app into login_button_center

images created after test

0962fbc

monsieurtanuki approved these changes Jul 28, 2022

View reviewed changes

monsieurtanuki merged commit 9acaddf into openfoodfacts:develop Jul 28, 2022

github-actions bot mentioned this pull request Jul 28, 2022

chore(develop): release 3.6.0 #2655

Merged

monsieurtanuki mentioned this pull request Jul 28, 2022

Login button not in whole width center #2059

Closed

github-actions bot mentioned this pull request Aug 10, 2022

chore(develop): release 3.7.0 #2735

Merged

github-actions bot mentioned this pull request Sep 6, 2022

chore(develop): release 3.14.0 #2951

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Login button whole width centre #2668

fix: Login button whole width centre #2668

prathamsoni11 commented Jul 27, 2022

AshAman999 commented Jul 27, 2022

prathamsoni11 commented Jul 27, 2022

AshAman999 commented Jul 27, 2022

prathamsoni11 commented Jul 28, 2022

AshAman999 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022 •

edited

Loading

monsieurtanuki commented Jul 28, 2022

M123-dev commented Jul 28, 2022

monsieurtanuki left a comment

monsieurtanuki Jul 27, 2022

monsieurtanuki Jul 28, 2022

prathamsoni11 Jul 28, 2022

monsieurtanuki Jul 28, 2022

prathamsoni11 Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022 •

edited

Loading

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki left a comment

fix: Login button whole width centre #2668

fix: Login button whole width centre #2668

Conversation

prathamsoni11 commented Jul 27, 2022

What

Screenshot

Fixes bug(s)

Part of

AshAman999 commented Jul 27, 2022

prathamsoni11 commented Jul 27, 2022

AshAman999 commented Jul 27, 2022

prathamsoni11 commented Jul 28, 2022

AshAman999 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022 • edited Loading

monsieurtanuki commented Jul 28, 2022

M123-dev commented Jul 28, 2022

monsieurtanuki left a comment

Choose a reason for hiding this comment

monsieurtanuki Jul 27, 2022

Choose a reason for hiding this comment

monsieurtanuki Jul 28, 2022

Choose a reason for hiding this comment

prathamsoni11 Jul 28, 2022

Choose a reason for hiding this comment

monsieurtanuki Jul 28, 2022

Choose a reason for hiding this comment

prathamsoni11 Jul 28, 2022

Choose a reason for hiding this comment

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022 • edited Loading

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki commented Jul 28, 2022

prathamsoni11 commented Jul 28, 2022

monsieurtanuki left a comment

Choose a reason for hiding this comment

prathamsoni11 commented Jul 28, 2022 •

edited

Loading

prathamsoni11 commented Jul 28, 2022 •

edited

Loading