fix: #2773 - appropriate "clear?" and "delete?" messages for user lists #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for user lists Impacted files: * `app_en.arb`: labels for user lists (clear? + delete?) * `app_fr.arb`: labels for user lists (clear? + delete?) * `product_list_page.dart`: now using the new "clear?" label for user lists * `product_list_user_dialog_helper.dart`: now localizing with the new "delete?" label for user lists
Codecov Report
@@ Coverage Diff @@
## develop #2778 +/- ##
==========================================
- Coverage 8.86% 7.12% -1.74%
==========================================
Files 161 218 +57
Lines 6623 10650 +4027
==========================================
+ Hits 587 759 +172
- Misses 6036 9891 +3855
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
VaiTon
reviewed
Aug 16, 2022
| @@ -215,8 +215,9 @@ class ProductListUserDialogHelper { | |||
| final bool? deleted = await showDialog<bool>( | |||
| context: context, | |||
| builder: (final BuildContext context) => SmoothAlertDialog( | |||
| title: 'Delete list?', | |||
There was a problem hiding this comment.
The point of this PR is to put an appropriate label:
- in this particular case, the title was no localized
- we need to be able to say "do you want to clear THIS list?" and/or "do you want to clear the HISTORY?"
- we could keep this title, but that would mean that 1. we should localize it and 2. it would be kind of duplicate with the more detailed message "clear this list" / "clear the history"
There was a problem hiding this comment.
In my opinion having a title, even a generic one, could make the decision faster. As a user I'd first like to read "Are you sure?" and then if I need an extended explanation I'm reading the body.
It's a personal preference though, nothing blocking so feel free to merge!
|
Thank you @VaiTon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
app_en.arb: labels for user lists (clear? + delete?)app_fr.arb: labels for user lists (clear? + delete?)product_list_page.dart: now using the new "clear?" label for user listsproduct_list_user_dialog_helper.dart: now localizing with the new "delete?" label for user listsWhat
Screenshot
Fixes bug(s)