Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text alignment in attribute chips #2786

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Aug 13, 2022

Before After
immagine immagine

@VaiTon VaiTon requested a review from a team as a code owner August 13, 2022 23:03
@codecov-commenter
Copy link

Codecov Report

Merging #2786 (a1d7a23) into develop (2ea0da3) will decrease coverage by 1.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2786      +/-   ##
==========================================
- Coverage     8.86%   7.04%   -1.82%     
==========================================
  Files          161     218      +57     
  Lines         6623   10640    +4017     
==========================================
+ Hits           587     750     +163     
- Misses        6036    9890    +3854     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 62.26% <0.00%> (-20.72%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) ⬇️
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 2.50% <0.00%> (-2.27%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
... and 237 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @VaiTon

@teolemon teolemon merged commit c5e5ef8 into openfoodfacts:develop Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants