Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH) Only the last miniature is displayed in product addition #2843

Closed
teolemon opened this issue Aug 25, 2022 · 3 comments
Closed

(GH) Only the last miniature is displayed in product addition #2843

teolemon opened this issue Aug 25, 2022 · 3 comments
Labels
🐛 bug Something isn't working good first issue Good for newcomers Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

What

  • Only the last miniature is displayed in product addition
    image
@teolemon teolemon added 🐛 bug Something isn't working Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. labels Aug 25, 2022
@AshAman999 AshAman999 mentioned this issue Aug 28, 2022
Merged
@AshAman999
Copy link
Member

@teolemon
Since we delete the cropped image from the cache when it's done uploading, the flutter engine doesn't find any file at that location to render that image, and also the cache file needs to be deleted explicitly when done uploading ,

Possible solutions:

  • Don't show the miniature pictures at all, rather use a green tick ✅ to show that it's done.

@teolemon
Copy link
Member Author

teolemon commented Sep 8, 2022

Looks good to me, let's propose that as part of the Grace Hopper hackathon :-)

@teolemon teolemon changed the title Only the last miniature is displayed in product addition (GH) Only the last miniature is displayed in product addition Sep 8, 2022
@M123-dev M123-dev mentioned this issue Sep 9, 2022
Merged
@monsieurtanuki
Copy link
Contributor

Looks like it's already been coded.
Screenshot_1703767406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working good first issue Good for newcomers Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
Revamp product addition to make instant scoring possible
Status: Done
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @monsieurtanuki @AshAman999