-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2863 - onboarding black tooltip now bottom positioned #2889
fix: #2863 - onboarding black tooltip now bottom positioned #2889
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2889 +/- ##
=======================================
Coverage 6.94% 6.94%
=======================================
Files 229 229
Lines 11155 11153 -2
=======================================
Hits 775 775
+ Misses 10380 10378 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I'm not really fan of it, because it forces to click the tooltip to continue. |
You're right, but it was already the case before. Actually you just had to click anywhere on the screen to dismiss the tooltip, not specifically the tooltip.
Again, the buttons were NOT accessible. They were visible, but could not be tapped on, unless you clicked before somewhere on the screen to dismiss the tooltip. Something did not work before, and it still doesn't: I haven't changed that, I've just moved the tooltip downwards. A solution would be to:
What do you think of that? |
I'm note sure of that, clicking on Next would prevent this. What about highlighting the nutriscore card instead? Whatever the screen size, there would be enough place for the bottom buttons. |
Then please try again: this happens when we run the test+screenshots, and this happened when I coded this PR.
That's why I suggested to:
You mean the tooltip landing just below the nutriscore card? Please consider my suggestion too. |
…n top Impacted file: * `knowledge_panel_page_template.dart`: higher tooltip; removed the "click anywhere on the screen" capture that prevented a direct click on items
@g123k I've raised a little the tooltip so that the next / previous buttons are visible. |
What
Screenshot
Fixes bug(s)