Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Finalizer for MLKitScanDecoder #2937

Merged
merged 2 commits into from
Sep 7, 2022
Merged

feat: Finalizer for MLKitScanDecoder #2937

merged 2 commits into from
Sep 7, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Sep 6, 2022 •
edited
Loading

What

  • A Finalizer is now used within MLKitScanDecoder to ensure the Isolate is well disposed when the class is destroyed

Note: It won't improve the camera or the barcode scanner, but should fix a potential Out Of Memory error.

More info on the Finalizer class:

@g123k g123k added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Sep 6, 2022
@g123k g123k self-assigned this Sep 6, 2022
@g123k g123k requested a review from a team as a code owner September 6, 2022 10:15
VaiTon
VaiTon approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some formatting details

packages/smooth_app/lib/pages/scan/mkit_scan_helper.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/pages/scan/mkit_scan_helper.dart Outdated Show resolved Hide resolved
@teolemon teolemon merged commit aefd743 into openfoodfacts:develop Sep 7, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Merged
@teolemon teolemon mentioned this pull request Sep 8, 2022
Closed
@g123k g123k deleted the mlkit_finalizer branch September 10, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@M123-dev M123-dev M123-dev approved these changes

@VaiTon VaiTon VaiTon approved these changes

Assignees

@g123k g123k

Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g123k @teolemon @VaiTon @M123-dev