-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: background tasks with classes #2994
refactor: background tasks with classes #2994
Conversation
New files: * `abstract_background_task.dart`: Abstract background task. * `background_task_details.dart`: Background task that changes product details (data, but no image upload). * `background_task_image.dart`: Background task about product image upload. Impacted files: * `add_basic_details_page.dart`: refactored the call to background task; minor refactoring * `background_task_helper.dart`: moved most of the code to new classes `AbstractBackgroundTask` and offsprings. * `edit_ingredients_page.dart`: refactored the call to background task * `nutrition_page_loaded.dart`: refactored the call to background task * `picture_capture_helper.dart`: refactored the call to background task * `simple_input_page.dart`: refactored the call to background task * `simple_input_page_helpers.dart`: added and implemented method `getTask`
Codecov Report
@@ Coverage Diff @@
## develop #2994 +/- ##
==========================================
+ Coverage 6.50% 6.51% +0.01%
==========================================
Files 241 244 +3
Lines 12031 12026 -5
==========================================
+ Hits 783 784 +1
+ Misses 11248 11242 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I am impressed, thanks a lot for the great refactoring
I just left a real few minor issues, Just come better comments suggestions
packages/smooth_app/lib/pages/product/add_basic_details_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/background/abstract_background_task.dart
Outdated
Show resolved
Hide resolved
Impacted files: * `abstract_background_task.dart` * `add_basic_details_page.dart`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @monsieurtanuki for this PR
Totally worth something to learn from
Thank you @AshAman999 for your enthusiastic review! |
I didn't give much thought when selecting the review dropdown, honestly, to me all of them looked the same |
New files:
abstract_background_task.dart
: Abstract background task.background_task_details.dart
: Background task that changes product details (data, but no image upload).background_task_image.dart
: Background task about product image upload.Impacted files:
add_basic_details_page.dart
: refactored the call to background task; minor refactoringbackground_task_helper.dart
: moved most of the code to new classesAbstractBackgroundTask
and offsprings.edit_ingredients_page.dart
: refactored the call to background tasknutrition_page_loaded.dart
: refactored the call to background taskpicture_capture_helper.dart
: refactored the call to background tasksimple_input_page.dart
: refactored the call to background tasksimple_input_page_helpers.dart
: added and implemented methodgetTask
What
Part of