Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refresh images from gallery screen #3023

Merged
merged 5 commits into from
Sep 16, 2022
Merged

fix: refresh images from gallery screen #3023

merged 5 commits into from
Sep 16, 2022

Conversation

AshAman999
Copy link
Member

What

  • Users can now pull to refresh the image gallery
  • I updated the whole product here and I am using provider cuz we are working on refreshing the product from the background, the images here will be automatically refreshed as well, just an added benefit

Screenshot

20220916_120949.mp4

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner September 16, 2022 07:19
monsieurtanuki
monsieurtanuki approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshAman999!
I'm not familiar enough with the gallery screen to understand everything, but the code looks rather OK.
In addition to my detailed comments, I don't see why you insist in using a Product parameter in all your new methods as you only use the barcode, that does not change, and that you could get from the widget.

packages/smooth_app/lib/pages/product/product_image_gallery_view.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/pages/product/product_image_gallery_view.dart Outdated Show resolved Hide resolved
@AshAman999 AshAman999 merged commit 58dbd43 into openfoodfacts:develop Sep 16, 2022
@github-actions github-actions bot mentioned this pull request Sep 16, 2022
Merged
@AshAman999 AshAman999 mentioned this pull request Sep 16, 2022
Closed
1 task
@monsieurtanuki monsieurtanuki mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

@M123-dev M123-dev Awaiting requested review from M123-dev

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@AshAman999 AshAman999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pull to refresh in the photo manager in edit mode
2 participants
@AshAman999 @monsieurtanuki