chore: Update assets #3057
Merged
chore: Update assets #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @M123-dev!
What if your curl command fails? It will crash the asset file, won't it?
Or do you consider that we're safe as long as we don't merge the PR?
|
If it fails we shouldn't merge (wait until next day 19 o'clock or manually re-run the script) also it doesn't open a PR if nothing has changed |
|
Also FYK the unchanged script should be just a onetime change. |
github-actions
bot
added
the
🤗 Onboarding
Codecov Report
@@ Coverage Diff @@
## develop #3057 +/- ##
=======================================
Coverage 6.47% 6.47%
=======================================
Files 246 246
Lines 12184 12184
=======================================
Hits 789 789
Misses 11395 11395 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
force-pushed
the
auto-update-assets
branch
3 times, most recently
from
d42b787 to
81b631e
Compare
github-actions
bot
force-pushed
the
auto-update-assets
branch
2 times, most recently
from
b1f63fb to
1c20a9a
Compare
github-actions
bot
force-pushed
the
auto-update-assets
branch
from
1c20a9a to
b0a7f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated update of asset cache