-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Downgrade to Flutter 3.0 #3244
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3244 +/- ##
==========================================
+ Coverage 7.66% 7.86% +0.19%
==========================================
Files 249 250 +1
Lines 12286 12315 +29
==========================================
+ Hits 942 968 +26
- Misses 11344 11347 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
Looks good to me!
That said, if it's just a matter of isolate
, perhaps we would be better off not using isolates while the flutter bug is not fixed.
If I remember well we only use them in the scan process.
That would mean the app would work with flutter 3.3, though it may stutter a little on the scan page.
Just a suggestion: try the app in flutter 3.3 without isolates. Suggestion that you can ignore :)
I'm going to merge this to get the build back in order when it comes to scanning |
We currently have an issue with release builds, but only with Flutter 3.3.
Without being able clearly able to identify the issue, we downgrade to Flutter 3.0, the time to find a real fix