Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Downgrade to Flutter 3.0 #3244

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 1, 2022

We currently have an issue with release builds, but only with Flutter 3.3.
Without being able clearly able to identify the issue, we downgrade to Flutter 3.0, the time to find a real fix

@g123k g123k added the flutter label Nov 1, 2022
@g123k g123k self-assigned this Nov 1, 2022
@g123k g123k requested a review from a team as a code owner November 1, 2022 09:03
@github-actions github-actions bot added dependencies GitHub goldens 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🧪 Tests labels Nov 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3244 (d0c6120) into develop (14cfed4) will increase coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head d0c6120 differs from pull request most recent head ce205d6. Consider uploading reports for the commit ce205d6 to get more accurate results

@@            Coverage Diff             @@
##           develop   #3244      +/-   ##
==========================================
+ Coverage     7.66%   7.86%   +0.19%     
==========================================
  Files          249     250       +1     
  Lines        12286   12315      +29     
==========================================
+ Hits           942     968      +26     
- Misses       11344   11347       +3     
Impacted Files Coverage Δ
...h_app/lib/cache/files/file_cache_manager_impl.dart 94.59% <ø> (ø)
...owledge_panels/knowledge_panel_world_map_card.dart 0.00% <0.00%> (ø)
...pp/lib/pages/onboarding/onboarding_bottom_bar.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)
...ib/generic_lib/dialogs/smooth_category_picker.dart 86.77% <0.00%> (-0.37%) ⬇️
packages/smooth_app/lib/database/dao_int.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/pages/crop_helper.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/database/dao_string.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/database/dao_product.dart 0.00% <0.00%> (ø)
...ackages/smooth_app/lib/helpers/network_config.dart 0.00% <0.00%> (ø)
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
Looks good to me!
That said, if it's just a matter of isolate, perhaps we would be better off not using isolates while the flutter bug is not fixed.
If I remember well we only use them in the scan process.
That would mean the app would work with flutter 3.3, though it may stutter a little on the scan page.
Just a suggestion: try the app in flutter 3.3 without isolates. Suggestion that you can ignore :)

@teolemon
Copy link
Member

teolemon commented Nov 1, 2022

I'm going to merge this to get the build back in order when it comes to scanning

@teolemon teolemon merged commit c52073d into openfoodfacts:develop Nov 1, 2022
@g123k g123k deleted the downgrade_3_0 branch November 1, 2022 14:10
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies flutter GitHub goldens 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🧪 Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants