Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty product addition #3265

Merged
merged 6 commits into from
Nov 5, 2022
Merged

fix: empty product addition #3265

merged 6 commits into from
Nov 5, 2022

Conversation

AshAman999
Copy link
Member

What

  • Empty products won't be added unless fields are updated

Fixes bug(s)

@AshAman999 AshAman999 requested a review from a team as a code owner November 4, 2022 16:13
@github-actions github-actions bot added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page labels Nov 4, 2022
@AshAman999 AshAman999 requested a review from M123-dev November 4, 2022 16:15
monsieurtanuki
monsieurtanuki approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshAman999!
Looks good to me, though I have some minor comments.
Please read them, but feel free to ignore them.

packages/smooth_app/lib/pages/product/add_new_product_page.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/pages/product/add_new_product_page.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/pages/product/add_new_product_page.dart Show resolved Hide resolved
packages/smooth_app/lib/pages/product/add_new_product_page.dart Outdated Show resolved Hide resolved
@teolemon teolemon changed the title fix: empty product additon fix: empty product addition Nov 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3265 (8196f66) into develop (c80f0c2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3265      +/-   ##
===========================================
- Coverage    10.53%   10.53%   -0.01%     
===========================================
  Files          249      249              
  Lines        12248    12250       +2     
===========================================
  Hits          1290     1290              
- Misses       10958    10960       +2
Impacted Files Coverage Δ
...pp/lib/generic_lib/widgets/smooth_back_button.dart 6.66% <ø> (ø)
...th_app/lib/pages/product/add_new_product_page.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <ø> (ø)
.../lib/pages/product/product_image_gallery_view.dart 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

teolemon commented Nov 5, 2022

thank you both, merging

@teolemon teolemon merged commit bf27a72 into openfoodfacts:develop Nov 5, 2022
@github-actions github-actions bot mentioned this pull request Nov 5, 2022
Merged
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

@M123-dev M123-dev Awaiting requested review from M123-dev

Assignees

@AshAman999 AshAman999

Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

Bug -vempty product added to history
5 participants
@AshAman999 @codecov-commenter @teolemon @monsieurtanuki @M123-dev