Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3266 - centered world map #3268

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

monsieurtanuki
Copy link
Contributor

What

  • When switching from/to flutter 3.3 we forgot some parameters for the map.
  • I must say I haven't tested the code.

Fixes bug(s)

@codecov-commenter
Copy link

Codecov Report

Merging #3268 (3d74aef) into develop (134ab47) will increase coverage by 2.67%.
The diff coverage is 15.78%.

@@             Coverage Diff             @@
##           develop    #3268      +/-   ##
===========================================
+ Coverage     7.86%   10.53%   +2.67%     
===========================================
  Files          250      249       -1     
  Lines        12315    12246      -69     
===========================================
+ Hits           968     1290     +322     
+ Misses       11347    10956     -391     
Impacted Files Coverage Δ
packages/smooth_app/lib/helpers/camera_helper.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/helpers/product_cards_helper.dart 0.00% <0.00%> (ø)
...owledge_panels/knowledge_panel_world_map_card.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.00% <0.00%> (ø)
...ib/pages/preferences/user_preferences_account.dart 20.97% <ø> (ø)
.../lib/pages/product/product_image_gallery_view.dart 0.00% <0.00%> (ø)
...pages/preferences/user_preferences_contribute.dart 59.45% <27.27%> (ø)
...ib/generic_lib/widgets/smooth_text_form_field.dart 87.50% <100.00%> (+84.86%) ⬆️
...th_app/lib/pages/user_management/sign_up_page.dart 52.96% <100.00%> (+52.50%) ⬆️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki changed the title fix: #3266 fix: #3266 - centered world map Nov 5, 2022
@monsieurtanuki monsieurtanuki merged commit 12a47b7 into openfoodfacts:develop Nov 5, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review! I hope it works.

@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All maps point to the default location in flutter_map
4 participants