Duplicate entries in Product Search

[anshpathania7]

What

• The entries are getting duplicated in product search page

Reason behind this behaviour

• This is happening because String is not being trimmed, "redbull", " redbull ", "redbull ".

• These are treated as 3 separate entries.

Steps to Reproduce

1. Search any product, then search again with some spaces before/after product name.

Expected behavior

Not to show duplicated entries

Screenshot

Smartphone model

• Device: Poco X3 Pro
• OS: Android 12

[AshAman999]

Indeed, there's this problem, perhaps these files would be interesting for you
packages\smooth_app\lib\pages\scan\search_page.dart

[monsieurtanuki]

@anshpathania7 I suggest that we systematically trim the user keywords when she clicks on the "search!" button: no duplicate in search history, and same result on the server.
In addition to that, maybe run a one-shot data cleaning to remove duplicates (but we're ok without that).

[anshpathania7]

By systematically you're referring to trim keywords in the search bar itself right? Also for server-side, shouldn't there be a check or data validation for keywords on server code(I'm guessing it's already there).

And, yes I don't think there's any need of one shot data clearing currently.

[monsieurtanuki]

By systematically...

I mean we let the user type whatever, but what we send to the server and we store in the history is to be trimmed before.

[anshpathania7]

Cool, This will be easy fix but should I patch this up for search query only? or There are other places in app where input needs to be trimmed? @monsieurtanuki @AshAman999

[monsieurtanuki]

@anshpathania7 There are not that many user inputs. If you can fix this one, that's good enough for the moment.