Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 3490 - check the Status of picture uploads #3517

Merged
merged 1 commit into from
Jan 4, 2023
Merged

fix: 3490 - check the Status of picture uploads #3517

merged 1 commit into from
Jan 4, 2023

Conversation

monsieurtanuki
Copy link
Contributor

@monsieurtanuki monsieurtanuki commented Jan 4, 2023 •
edited
Loading

Impacted files:

  • background_task_image.dart: throws an exception if the upload status is not OK
  • background_task_manager.dart: logs a Sentry error if the executed background task throws an exception

What

  • It won't fix the issue but at least now we log the unsuccessful uploads.

Part of

@monsieurtanuki
fix: 3490 - check the Status of picture uploads
e682f9e 
Impacted files:
* `background_task_image.dart`: throws an exception if the upload status is not OK
* `background_task_manager.dart`: logs a Sentry error if the executed background task throws an exception
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner January 4, 2023 19:19
teolemon
teolemon approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping that it indeed throws an exception 🤞

@monsieurtanuki monsieurtanuki merged commit 01b4fbf into openfoodfacts:develop Jan 4, 2023
@monsieurtanuki
Copy link
Contributor Author

The exception displays a debugPrint and sends an error to Sentry.
We'll see...

@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Merged
@teolemon
Copy link
Member

teolemon commented Jan 4, 2023

Just reproduced but no exception. It fails so fast that I believe it's not doing anything at all (even not passing back the image)

@monsieurtanuki
Copy link
Contributor Author

Just reproduced but no exception. It fails so fast that I believe it's not doing anything at all (even not passing back the image)

Just checking: on the Crop page you do click on the Confirm button and you do get the snackbar message, right?

@teolemon
Copy link
Member

teolemon commented Jan 4, 2023 •
edited
Loading

@monsieurtanuki
I do click on confirm but no snack-bar at all.

@monsieurtanuki
Copy link
Contributor Author

I do click on confirm but no snack-bar at all.

You are supposed to see a snack-bar.
I added debugs in #3519: a bit lousy but that should be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

@AshAman999 AshAman999 Awaiting requested review from AshAman999

Assignees

@monsieurtanuki monsieurtanuki

Labels
background tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monsieurtanuki @teolemon