Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3494 pop dialog navigator properly #3528

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

Sudhanva-Nadiger
Copy link
Contributor

Impacted file:

  • user_preferences_connect.dart

What

  • popping of dialog navigator is now working properly in connect with us > send us an email section.
  • settingRootnavigation of context to true (default value will be false) will make the dialog pop off the screen.

Screenshot

openFoodFact_dialogIssue_solved.mp4

Fixes bug(s)

Part of

Impacted file:
* `user_preferences_connect.dart`
@codecov-commenter
Copy link

Codecov Report

Merging #3528 (e3a7f81) into develop (d61ca4b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3528      +/-   ##
===========================================
+ Coverage    11.05%   11.07%   +0.01%     
===========================================
  Files          262      262              
  Lines        12978    12955      -23     
===========================================
  Hits          1435     1435              
+ Misses       11543    11520      -23     
Impacted Files Coverage Δ
packages/smooth_app/lib/pages/image_crop_page.dart 0.00% <ø> (ø)
...ib/pages/preferences/user_preferences_connect.dart 6.81% <0.00%> (ø)
...th_app/lib/pages/product/product_image_viewer.dart 0.00% <ø> (ø)
...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Sudhanva-Nadiger

@M123-dev M123-dev merged commit a5949dc into openfoodfacts:develop Jan 6, 2023
@M123-dev
Copy link
Member

M123-dev commented Jan 6, 2023

Congrats on your first contribution here 🎉

@Sudhanva-Nadiger
Copy link
Contributor Author

Thanks @M123-dev !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acknowledge button for sending Email action is not disappearing after the process
4 participants