Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3526 - add OTHER picture from product gallery #3544

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • product_image_gallery_view.dart: added a FAB in order to add an OTHER picture

What

  • Added a FAB in the product picture gallery in order to add an OTHER picture.
  • Still find it frustrating to add a picture that I will never see again, but that's another story.
  • I cannot quite visualize how to add that button in the recycling pages without them getting too obscure. @manon-corneille suggestions are welcome!

Screenshot

gallery crop page
Capture d’écran 2023-01-06 à 19 41 19 Capture d’écran 2023-01-06 à 19 41 49

Yes it's the same waterfall as in "Ingredients" but that's a coincidence.

Part of

Impacted file:
* `product_image_gallery_view.dart`: added a FAB in order to add an OTHER picture
@codecov-commenter
Copy link

Codecov Report

Merging #3544 (466b7d1) into develop (62f7769) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3544   +/-   ##
========================================
  Coverage    11.07%   11.08%           
========================================
  Files          262      262           
  Lines        12955    12949    -6     
========================================
  Hits          1435     1435           
+ Misses       11520    11514    -6     
Impacted Files Coverage Δ
.../lib/pages/product/product_image_gallery_view.dart 0.00% <0.00%> (ø)
...ckages/smooth_app/lib/database/transient_file.dart 0.00% <0.00%> (ø)
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki merged commit 46056bc into openfoodfacts:develop Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants