Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3526 - added "add extra photo" button for both edit packaging pages #3560

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_en.arb: added a label for the new "add extra packaging photo" button
  • edit_new_packagings.dart: added an "add extra packaging photo" button
  • ocr_helper.dart: added an "has add extra photo?" method
  • ocr_ingredients_helper.dart: implemented the new "has add extra photo?" method (false)
  • ocr_packaging_helper.dart: implemented the new "has add extra photo?" method (true)
  • ocr_widget.dart: added an "add extra packaging photo" button; refactored as StatefulWidget as needed by new button

What

  • Added an "add extra packaging photo" in both edit packaging pages (ocr and structure packaging)

Screenshot

structured packaging ocr
Capture d’écran 2023-01-10 à 09 46 55 Capture d’écran 2023-01-10 à 09 44 09

Fixes bug(s)

…ages

Impacted files:
* `app_en.arb`: added a label for the new "add extra packaging photo" button
* `edit_new_packagings.dart`: added an "add extra packaging photo" button
* `ocr_helper.dart`: added an "has add extra photo?" method
* `ocr_ingredients_helper.dart`: implemented the new "has add extra photo?" method (`false`)
* `ocr_packaging_helper.dart`: implemented the new "has add extra photo?" method (`true`)
* `ocr_widget.dart`: added an "add extra packaging photo" button; refactored as `StatefulWidget` as needed by new button
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Eventually, we'll have to solve the dissonance of having two screens, but that requires some more thinking.

@monsieurtanuki monsieurtanuki merged commit 9f93cee into openfoodfacts:develop Jan 14, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

@teolemon teolemon added image upload ✏️ Editing - Packaging input Related to the structured input of food packaging. labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reintroduce the "Add more photos" button in the photo section of the edit mode
2 participants