Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue website link overflow #3607

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

Akashsri3bi
Copy link
Contributor

No overflow issues on website link in product description page ( Ellipsis)

@Akashsri3bi Akashsri3bi requested a review from a team as a code owner January 21, 2023 13:23
@github-actions github-actions bot added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page labels Jan 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3607 (acdd21c) into develop (66cdbf2) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3607      +/-   ##
===========================================
- Coverage    11.08%   10.92%   -0.17%     
===========================================
  Files          264      266       +2     
  Lines        13086    13136      +50     
===========================================
- Hits          1451     1435      -16     
- Misses       11635    11701      +66     
Impacted Files Coverage Δ
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)
...ooth_app/lib/background/background_task_badge.dart 8.33% <0.00%> (-41.67%) ⬇️
...kages/smooth_app/lib/pages/offline_tasks_page.dart 1.72% <0.00%> (-0.66%) ⬇️
packages/smooth_app/lib/pages/page_manager.dart 1.75% <0.00%> (ø)
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/edit_new_packagings.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% <0.00%> (ø)
...th_app/lib/background/background_task_details.dart 1.36% <0.00%> (ø)
...th_app/lib/background/background_task_manager.dart 0.00% <0.00%> (ø)
...h_app/lib/background/abstract_background_task.dart 0.00% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Akashsri3bi

@M123-dev M123-dev merged commit db3aaa3 into openfoodfacts:develop Jan 21, 2023
@Akashsri3bi Akashsri3bi deleted the ak2 branch January 27, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants