chore: Warning when running out of main.dart #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got some questions on slack from people who had problems running the app: root isolate couldn't be started Which happens when you try to run the app from main.dart
monsieurtanuki
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Hi @M123-dev!
Not sure what the pubspec.lock does here...
The rest looks OK.
| url: "https://pub.dev" | ||
| source: hosted | ||
| version: "0.8.6+6" | ||
| version: "0.8.6+7" |
| url: "https://pub.dev" | ||
| source: hosted | ||
| version: "6.0.18" | ||
| version: "6.1.0" |
| @@ -31,6 +33,23 @@ import 'package:smooth_app/themes/smooth_theme.dart'; | |||
| import 'package:smooth_app/themes/theme_provider.dart'; | |||
| import 'package:smooth_app/widgets/smooth_scaffold.dart'; | |||
|
|
|||
| void main() { | |||
There was a problem hiding this comment.
Haven't checked if it works, but it's a good idea!
Codecov Report
@@ Coverage Diff @@
## develop #3687 +/- ##
==========================================
- Coverage 9.35% 9.34% -0.01%
==========================================
Files 272 272
Lines 13712 13723 +11
==========================================
Hits 1283 1283
- Misses 12429 12440 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I had a weird android native problem which I thought would be fixed by pub upgrade. In the end, it was just me not having java not set up the right way, but that's why it changed. |
|
Thanks for the review @monsieurtanuki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got some questions on slack from people who had problems running the app:
root isolate couldn't be started
Which happens when you try to run the app from main.dart