fix: 3459 - Added a shortcut in app settings to In-app settings #3726
Conversation
Adiii1436
changed the title
| Widget build(BuildContext context) { | ||
| final AppLocalizations appLocalizations = AppLocalizations.of(context); | ||
|
|
||
| return GestureDetector( |
There was a problem hiding this comment.
Hey, listTile gives onTap functionality, we can make use of that.
There was a problem hiding this comment.
ListTile only contains the text. If I'll provide ontap() function here app-settings will only open when I'll click on text area not on the setting icon. App-settings should open when I click wherever on that particular row.
There was a problem hiding this comment.
yes, listtile gives leading and trailiing property, use that instead of seperate padding. so onTap on list tile will handle tap on anywhere on whole list.
There was a problem hiding this comment.
Yes! this should be the nice solution. Thanks @Sudhanva-Nadiger let me make changes.
There was a problem hiding this comment.
I have made changes @Sudhanva-Nadiger
packages/smooth_app/pubspec.yaml
Outdated
| @@ -45,6 +45,7 @@ dependencies: | |||
| url_launcher: 6.1.3 | |||
| visibility_detector: 0.3.3 | |||
| assorted_layout_widgets: 6.1.1 | |||
| app_settings: | |||
There was a problem hiding this comment.
add version of the package
| @@ -1521,4 +1528,4 @@ packages: | |||
| version: "3.1.1" | |||
| sdks: | |||
| dart: ">=2.17.0 <3.0.0" | |||
| flutter: ">=3.0.0" | |||
| flutter: ">=3.0.1" | |||
|
@M123-dev why test is failing? |
Codecov Report
@@ Coverage Diff @@
## develop #3726 +/- ##
===========================================
- Coverage 10.42% 10.41% -0.01%
===========================================
Files 272 272
Lines 13804 13821 +17
===========================================
+ Hits 1439 1440 +1
- Misses 12365 12381 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| style: const TextStyle( | ||
| color: Color.fromRGBO(193, 193, 193, 1.0), | ||
| letterSpacing: 0.5, | ||
| fontSize: 14, | ||
| ), |
There was a problem hiding this comment.
We have a global text style
Theme.of(context).textTheme.bodyText2
(or bodyText1 or something else in there)
Could you use this one, if you need more fine control you can use .copyWith( ... ) behind it
There was a problem hiding this comment.
This way it's working with dark and light theme and other factors like accessibility
There was a problem hiding this comment.
Made the changes @M123-dev
Fixed #3459
