Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS build is failing due to mobile_scanner #3780

Closed
M123-dev opened this issue Mar 17, 2023 · 11 comments · Fixed by #3822
Closed

iOS build is failing due to mobile_scanner #3780

M123-dev opened this issue Mar 17, 2023 · 11 comments · Fixed by #3822
Labels
🐛 bug Something isn't working 🍎 iOS iOS specific issues or PRs 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…

Comments

@M123-dev
Copy link
Member

What

Looks like we have to upgrade xcode

@M123-dev
Copy link
Member Author

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Mar 17, 2023

What about #3779?

@M123-dev
Copy link
Member Author

@monsieurtanuki
Copy link
Contributor

I've just created juliansteenbakker/mobile_scanner#544

@teolemon teolemon added 🍎 iOS iOS specific issues or PRs 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Mar 20, 2023
@monsieurtanuki
Copy link
Contributor

@M123-dev Just curious: where the hell is the mac computer/server that is used in the CI/CD? Shouldn't it be upgraded to the latest macOS version?

@monsieurtanuki
Copy link
Contributor

@M123-dev Is the issue still relevant after you upgrade xcode? I mean, that will still be impossible on my old macbook anyway, but is that OK with upgradable devices?

@M123-dev
Copy link
Member Author

I actually don't know. I've never owned an Apple device, the servers where the builds are running on are hosted by GitHub (or now Microsoft IDK) for free as the repository is public.

They provide some runners, we are using macos-latest which is: macOS Monterey 12

So no way to update this as long as we plan to self-host something like this if there is a different way to update Xcode I don't know

https://docs.github.com/de/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Mar 28, 2023

It looks like we can run up to Xcode 14.2 on macOS Monterey 12.5 (cf. https://developer.apple.com/support/xcode/).
Related: I've created juliansteenbakker/mobile_scanner#568, which is supposed to solve the issue.

@juliansteenbakker
Copy link

juliansteenbakker commented Mar 28, 2023

Thanks for the PR on the mobile_scanner project. I didn't have much time this week to work on this so my apologies for the delay.

@juliansteenbakker
Copy link

I have merged the code. Is it possible to check if it's working now with the code on the master branch?

  mobile_scanner:
    git:
      url: https://github.com/juliansteenbakker/mobile_scanner.git
      ref: master

@monsieurtanuki
Copy link
Contributor

Thank you @juliansteenbakker: I've just created #3822.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🍎 iOS iOS specific issues or PRs 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

4 participants