fix: 3816 - upgrade to mlkit 4.0.0 and clean rebuild of the pods #3837
Conversation
Impacted files: * `ios-release-to-org-openfoodfacts-scanner.yml`: clean rebuild of the `pod`s * `Podfile.lock`: wtf * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded `mobile_scanner`, that upgraded to mlkit 4.0.0
Codecov Report
@@ Coverage Diff @@
## develop #3837 +/- ##
========================================
Coverage 10.77% 10.77%
========================================
Files 269 269
Lines 13416 13416
========================================
Hits 1446 1446
Misses 11970 11970 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
added
🤳 MLKit
🤳🥫 Scan
There was a problem hiding this comment.
Now we rebuild the pods on every release. Didn't we decide to rather update them on every opened PR and commit the new podspec to it
Does this even have any effect on the code base and the developers, I don't know. When running flutter run, they should install anyway don't they.
There was a problem hiding this comment.
Now we rebuild the pods on every release. Didn't we decide to rather update them on every opened PR and commit the new podspec to it
That would probably make sense; here it's just a test. And it looks like the pods failed even when not related to a release, just a PR merge, didn't they?
Which yml file would that be?
Does this even have any effect on the code base and the developers, I don't know. When running flutter run, they should install anyway don't they.
Actually I'm (temporarily?) not very affected either, as for some reason flutter builds have started failing on my ios emulator for a couple of weeks. It looks like I need to upgrade to Xcode 14 and Monterey, which is not straightforward (but still possible) on my macbook. For the next macos version that will be impossible because apple decided so.
| @@ -105,7 +105,7 @@ jobs: | |||
| VERSION_CODE: ${{ inputs.VERSION_CODE }} | |||
|
|
|||
| - name: Build app | |||
| run: cd ./packages/smooth_app && cd ios && pod update Sentry && pod update GoogleMLKit/BarcodeScanning && cd .. && flutter build ios --release --no-codesign -t lib/entrypoints/ios/main_ios.dart | |||
| run: cd ./packages/smooth_app && cd ios && rm -rf Pods && rm Podfile.lock && flutter pub get && pod install && cd .. && flutter build ios --release --no-codesign -t lib/entrypoints/ios/main_ios.dart | |||
There was a problem hiding this comment.
I'm guessing flutter pub get will fail, as it is called in the /ios folder
There was a problem hiding this comment.
I'm guessing
flutter pub getwill fail, as it is called in the/iosfolder
No it's OK, as long as flutter is in the PATH (which is likely).
|
Thank you @M123-dev for the review! Again, it's rather a test, but if we could get rid with those painful pod issues we could spend more time on painful issues that are not related to pods 😉 |
Impacted files:
ios-release-to-org-openfoodfacts-scanner.yml: clean rebuild of thepodsPodfile.lock: wtfpubspec.lock: wtfpubspec.yaml: upgradedmobile_scanner, that recently upgraded to mlkit 4.0.0What
mobile_scanner- now we point to the regular pub.dev versionpods too, which is a bit experimental but could prove useful given the confusion around iospodsPart of