Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: localizations 3.7 #3841

Merged

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_ar.arb
  • app_be.arb
  • app_cs.arb
  • app_da.arb
  • app_de.arb
  • app_el.arb
  • app_eu.arb
  • app_he.arb
  • app_it.arb
  • app_nl.arb
  • app_pl.arb
  • app_pt.arb
  • app_ro.arb

What

  • Recently, and probably from flutter 3.7, some incoherences were detected by the localization generator as "ICU Syntax Warning", at each app reload or flutter pub get
  • Typically, it looks like duplicate tags were inserted, like one as =1 already existed.
[app_pt.arb:user_list_length] ICU Syntax Warning: The plural part specified
below is overridden by a later plural part.
    {count,plural, one {}=0{Lista vazia} =1{Um produto} other{{count} produtos}}
                   ^
  • The idea in the current PR is to remove duplicates.

Following are the impacted localizations:

  • [app_ar.arb:plural_compare_x_products]
    • [app_ar.arb:product_list_reloading_in_progress_multiple]
    • [app_ar.arb:product_list_reloading_in_progress_multiple]
    • [app_ar.arb:product_list_reloading_success_multiple]
    • [app_ar.arb:product_list_reloading_success_multiple]
  • [app_be.arb:user_list_length]
  • [app_cs.arb:plural_ago_days]
    • [app_cs.arb:plural_ago_hours]
    • [app_cs.arb:plural_ago_minutes]
    • [app_cs.arb:plural_ago_months]
    • [app_cs.arb:product_list_reloading_in_progress_multiple]
    • [app_cs.arb:user_list_length]
  • [app_da.arb:plural_ago_days]
    • [app_da.arb:plural_ago_hours]
    • [app_da.arb:plural_ago_minutes]
    • [app_da.arb:plural_ago_months]
    • [app_da.arb:plural_ago_weeks]
    • [app_da.arb:plural_compare_x_products]
    • [app_da.arb:product_list_reloading_in_progress_multiple]
    • [app_da.arb:product_list_reloading_success_multiple]
    • [app_da.arb:user_list_length]
  • [app_de.arb:plural_ago_days]
  • [app_el.arb:user_list_length]
  • [app_eu.arb:plural_ago_days]
    • [app_eu.arb:plural_ago_hours]
    • [app_eu.arb:plural_ago_minutes]
    • [app_eu.arb:plural_ago_months]
    • [app_eu.arb:plural_ago_weeks]
    • [app_eu.arb:plural_compare_x_products]
  • [app_he.arb:plural_ago_days]
    • [app_he.arb:product_list_reloading_in_progress_multiple]
    • [app_he.arb:product_list_reloading_success_multiple]
    • [app_he.arb:user_list_length]
  • [app_it.arb:plural_ago_days]
    • [app_it.arb:plural_ago_hours]
    • [app_it.arb:plural_ago_minutes]
    • [app_it.arb:plural_ago_months]
    • [app_it.arb:plural_ago_weeks]
    • [app_it.arb:plural_compare_x_products]
    • [app_it.arb:product_list_reloading_in_progress_multiple]
    • [app_it.arb:product_list_reloading_success_multiple]
  • [app_nl.arb:user_list_length]
  • [app_pl.arb:user_list_length]
  • [app_pt.arb:user_list_length]
  • [app_ro.arb:plural_ago_days]
    • [app_ro.arb:plural_ago_hours]
    • [app_ro.arb:plural_ago_minutes]
    • [app_ro.arb:plural_ago_months]
    • [app_ro.arb:plural_ago_weeks]
    • [app_ro.arb:plural_compare_x_products]
    • [app_ro.arb:product_list_reloading_in_progress_multiple]
    • [app_ro.arb:product_list_reloading_success_multiple]
    • [app_ro.arb:user_list_length]

Impacted files:
* `app_ar.arb`
* `app_be.arb`
* `app_cs.arb`
* `app_da.arb`
* `app_de.arb`
* `app_el.arb`
* `app_eu.arb`
* `app_he.arb`
* `app_it.arb`
* `app_nl.arb`
* `app_pl.arb`
* `app_pt.arb`
* `app_ro.arb`
@codecov-commenter
Copy link

Codecov Report

Merging #3841 (9af8565) into develop (c232320) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3841   +/-   ##
========================================
  Coverage    10.77%   10.77%           
========================================
  Files          269      269           
  Lines        13419    13419           
========================================
  Hits          1446     1446           
  Misses       11973    11973           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki, we should fix them in crowdin as well, but that's a good start

@monsieurtanuki monsieurtanuki merged commit 00d8450 into openfoodfacts:develop Apr 4, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for the review!
You're probably right, the fix needs to go upstream too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants