Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ProductQuery.getLanguage() is now not nullable #3896

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • One of the first things we do in the app init is setting the language. There are no accidental cases or typical use cases when the language is supposed to be null.
  • For a better understanding of the app, it's better to make this method explicitly return a non null value.

Part of

@codecov-commenter
Copy link

Codecov Report

Merging #3896 (adb4311) into develop (85a3525) will not change coverage.
The diff coverage is 9.09%.

@@           Coverage Diff            @@
##           develop    #3896   +/-   ##
========================================
  Coverage    10.68%   10.68%           
========================================
  Files          270      270           
  Lines        13428    13428           
========================================
  Hits          1435     1435           
  Misses       11993    11993           
Impacted Files Coverage Δ
..._app/lib/pages/product/add_basic_details_page.dart 0.00% <0.00%> (ø)
...kages/smooth_app/lib/pages/product/ocr_helper.dart 0.00% <0.00%> (ø)
...app/lib/pages/product/ordered_nutrients_cache.dart 0.00% <0.00%> (ø)
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% <0.00%> (ø)
...app/lib/pages/product/simple_input_text_field.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)
...ages/smooth_app/lib/query/paged_product_query.dart 8.33% <ø> (ø)
.../smooth_app/lib/query/product_questions_query.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/query/questions_query.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/query/product_query.dart 8.10% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@g123k g123k merged commit d8a5fb5 into openfoodfacts:develop Apr 24, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants