-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 3897 - no language selector for gallery, only for swipeable page #3924
feat: 3897 - no language selector for gallery, only for swipeable page #3924
Conversation
Main changes: * `app_en.arb`: added 2 translations ("no image" / "no image for that language") * `app_fr.arb`: added 2 translations ("no image" / "no image for that language") * `nutrition_page_loaded.dart`: removed an implicit `language` parameter * `product_cards_helper.dart`: refactoring * `product_image_gallery_view.dart`: removed the language selector * `product_image_swipeable_view.dart`: removed the language parameter; now we always start with the app language * `product_image_viewer.dart`: now always displays the (non) image for the specified language, with additional labels; added explicit `language` parameters * `transient_file.dart`: new method `getImageLanguages` Added explicit `language` parameters for: * `add_new_product_page.dart`: added an explicit `language` parameter * `background_task_crop.dart`: added an explicit `language` parameter * `background_task_image.dart`: added an explicit `language` parameter * `background_task_unselect.dart`: added an explicit `language` parameter * `edit_ingredients_page.dart`: added an explicit `language` parameter * `edit_new_packagings.dart`: added an explicit `language` parameter * `image_crop_page.dart`: added an explicit `language` parameter * `image_upload_card.dart`: added an explicit `language` parameter * `new_crop_page.dart`: added an explicit `language` parameter * `product_image_local_button.dart`: added an explicit `language` parameter * `product_image_server_button.dart`: added an explicit `language` parameter * `uploaded_image_gallery.dart`: added an explicit `language` parameter
Codecov Report
@@ Coverage Diff @@
## develop #3924 +/- ##
===========================================
- Coverage 10.63% 10.62% -0.01%
===========================================
Files 268 268
Lines 13494 13506 +12
===========================================
Hits 1435 1435
- Misses 12059 12071 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Thank you @teolemon for your review! There's still a minor bug when you unselect an image that you just added (it's not taken into account immediately), that I'm about to fix. The bug was already there before the multilingual feature. |
What
Screenshot
App in French
Fixes bug(s)
Files
Main changes:
app_en.arb
: added 2 translations ("no image" / "no image for that language")app_fr.arb
: added 2 translations ("no image" / "no image for that language")nutrition_page_loaded.dart
: removed an implicitlanguage
parameterproduct_cards_helper.dart
: refactoringproduct_image_gallery_view.dart
: removed the language selectorproduct_image_swipeable_view.dart
: removed the language parameter; now we always start with the app languageproduct_image_viewer.dart
: now always displays the (non) image for the specified language, with additional labels; added explicitlanguage
parameterstransient_file.dart
: new methodgetImageLanguages
Added explicit
language
parameters for:add_new_product_page.dart
background_task_crop.dart
background_task_image.dart
background_task_unselect.dart
edit_ingredients_page.dart
edit_new_packagings.dart
image_crop_page.dart
image_upload_card.dart
new_crop_page.dart
product_image_local_button.dart
product_image_server_button.dart
uploaded_image_gallery.dart