feat: 3835 - country selector similar to language selector #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `consent_analytics_page.dart`: minor refactoring * `country_selector.dart`: now using the preferences for initial country code; same UI as language selector * `main.dart`: minor refactoring * `next_button.dart`: minor refactoring * `onboarding_flow_navigator.dart`: refactoring around `OnboardingPage` * `permissions_page.dart`: minor refactoring * `product_query.dart`: minor refactoring * `user_preferences.dart`: minor refactoring * `user_preferences_dev_mode.dart`: minor refactoring * `user_preferences_page.dart`: minor UI fix (app bar title on 2 lines) * `user_preferences_settings.dart`: added the "selected language" parameter; minor refactoring * `welcome_page.dart`: fixed a visual overflow bug
github-actions
bot
added
📈 Analytics
Codecov Report
@@ Coverage Diff @@
## develop #3936 +/- ##
===========================================
+ Coverage 10.99% 11.01% +0.01%
===========================================
Files 264 264
Lines 13051 13032 -19
===========================================
Hits 1435 1435
+ Misses 11616 11597 -19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
May 6, 2023
There was a problem hiding this comment.
Thanks a lot @monsieurtanuki, great to have it behave the same
| ); | ||
| case OnboardingPage.CONSENT_PAGE: | ||
| return _wrapWidgetInCustomBackNavigator( | ||
| context, | ||
| page, | ||
| ConsentAnalyticsPage(getBackgroundColor(page)), | ||
| ConsentAnalyticsPage(backgroundColor), |
There was a problem hiding this comment.
I know it's not from you but I am wondering why don't we just have the color inside the page
|
Thank you @M123-dev for your review! Regarding the colors being defined outside of the pages, I wouldn't mind if it was coded differently but after all, that forces developers to think about a different color for each onboarding page. Let's keep it that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
OnboardingPage. I was in a "Am I crazy or what?" mode for several days and tried everything to fix my issue. Was there a flaw in theprovider? Spoiler alert: no there wasn't, I just coded something inappropriately that cleared the data I'd just entered...Screenshots
Fixes bug(s)
Files
consent_analytics_page.dart: minor refactoringcountry_selector.dart: now using the preferences for initial country code; same UI as language selectormain.dart: minor refactoringnext_button.dart: minor refactoringonboarding_flow_navigator.dart: refactoring aroundOnboardingPagepermissions_page.dart: minor refactoringproduct_query.dart: minor refactoringuser_preferences.dart: minor refactoringuser_preferences_dev_mode.dart: minor refactoringuser_preferences_page.dart: minor UI fix (app bar title on 2 lines)user_preferences_settings.dart: added the "selected language" parameter; minor refactoringwelcome_page.dart: fixed a visual overflow bug