Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3980 - refresh of the ordered nutrients #3997

Merged
merged 2 commits into from
May 23, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • There was a typo in off-dart about mono and poly unsaturated fats, that prevented us from using them. That was fixed in 2.5.1
  • The current PR upgrades to 2.5.1, and also changes the ordered nutrient cache management - now we refresh frequently the ordered nutrient cache (we used to download only once).

Screenshot

before after
Screenshot_2023-05-21-14-03-47 Screenshot_2023-05-21-15-03-35

Fixes bug(s)

Impacted files

  • ordered_nutrients_cache.dart: now we cache the downloaded data in static - it used to be in database but then was never refreshed
  • pubspec.lock: wtf
  • pubspec.yaml: upgraded openfoodfacts to 2.5.1

Impacted files:
* `ordered_nutrients_cache.dart`: now we cache the downloaded data in static - it used to be in database but then was never refreshed
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded openfoodfacts to 2.5.1
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #3997 (bfdce6d) into develop (96426b2) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3997   +/-   ##
========================================
  Coverage    10.95%   10.95%           
========================================
  Files          266      266           
  Lines        13105    13103    -2     
========================================
  Hits          1435     1435           
+ Misses       11670    11668    -2     
Impacted Files Coverage Δ
...app/lib/pages/product/ordered_nutrients_cache.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

thanks @monsieurtanuki, merging

@teolemon teolemon merged commit ec7113d into openfoodfacts:develop May 23, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mono- poly- unsaturated
4 participants