fix: 4219 - check if new picture is big enough before server upload #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `app_en.arb`: added 2 labels for a "too small image" dialog! * `background_task_image.dart`: now we check before server call if the image is big enough * `crop_page.dart`: now we check if the image is big enough before new image upload * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded crop_image for controller bug fix
Codecov Report
@@ Coverage Diff @@
## develop #4224 +/- ##
===========================================
- Coverage 11.00% 10.96% -0.05%
===========================================
Files 282 282
Lines 14015 14069 +54
===========================================
Hits 1543 1543
- Misses 12472 12526 +54
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
approved these changes
Jun 24, 2023
| ), | ||
| 1 / cropConversionFactor, | ||
| ); | ||
| switch (CropRotationExtension.fromDegrees(rotationDegrees)!) { |
There was a problem hiding this comment.
FYI in that kind of situation a return switch from Dart 3 may look (a bit) better
There was a problem hiding this comment.
FYI in that kind of situation a return switch from Dart 3 may look (a bit) better
@g123k Fair enough!
I wouldn't say it looks better (just a matter of taste), but thank you for reminding me the new dart syntax!
|
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Impacted files
app_en.arb: added 2 labels for a "too small image" dialog!background_task_image.dart: now we check before server call if the image is big enoughcrop_page.dart: now we check if the image is big enough before new image uploadpubspec.lock: wtfpubspec.yaml: upgraded crop_image for controller bug fix