-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Some improvements for the carousel (changing pages, a11n…) #4225
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4225 +/- ##
===========================================
- Coverage 10.93% 10.91% -0.03%
===========================================
Files 282 282
Lines 14096 14119 +23
===========================================
- Hits 1542 1541 -1
- Misses 12554 12578 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If a vibration part is moved to the actual movement on the carousel, how do we know a barcode was scanned ? |
We know when a new barcode is scanned when the controller moves to a new page, and not by a swipe gesture. |
Merge conflict @g123k |
…ed by the old scanner
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
b113d50
to
5af9906
Compare
Hi everyone,
The carousel works when now, but sometimes it moves in all directions when barcodes are detected.
Here are the improvements implements:
I'm not 100% sure that it will prevent the weird behavior that when a barcode is scanned, sometimes it goes back to the first card. But after my changes, I can't reproduce it anymore, so let's 🤞.
As always, a video is better than words: https://github.com/openfoodfacts/smooth-app/assets/246838/c23c40c2-6f40-4327-81b8-4587050ca80b