feat: 4041 - now displaying user lists in "List" nav tab

[monsieurtanuki]

What

• When the user clicked on the "select the other product lists" button, the user lists were not present.
• Now the user lists are present, and the user can create new user lists.

Screenshot

Part of

• Defragment the history/list experience #4041

Files

New file:

• all_product_list_page.dart: Page that lists all product lists.

Impacted files:

• all_user_product_list_page.dart: simplified thanks to a new not async getter of all user product lists
• dao_product_list.dart: split the "get user lists" method in two - one not async, one async with barcode checks
• new_product_page.dart: minor refactoring
• product_list_page.dart: now using new page AllProductListPage in order to list all product lists
• product_list_popup_items.dart: fixed a label; removed a class we don't use anymore as we put lists and actions in different buttons
• product_list_user_dialog_helper.dart: minor refactoring

[monsieurtanuki]

Hi @g123k!
I added the feature ("user lists") with a simple interface. I know you have more ambitious UI expectations, but at least the feature is implemented.

[g123k]

I think you forgot to translate this one

[g123k]

It seems you also have an issue with a missing const constructor.

[monsieurtanuki]

Thank you @g123k for your review!

• indeed a StatelessWidget is enough - I copied a code that used setState once but in a part that I did not copy
• I've localized the label - after you implicitly agreed that the UI was decent enough
• I don't understand itemExtent so I don't use it, and I always chose code maintainability over hypothetical minor performance improvement

[g123k]

Thank you @g123k for your review!

• indeed a StatelessWidget is enough - I copied a code that used setState once but in a part that I did not copy
• I've localized the label - after you implicitly agreed that the UI was decent enough
• I don't understand itemExtent so I don't use it, and I always chose code maintainability over hypothetical minor performance improvement

Perfect!
For ListView.builder, the idea is that Flutter tries to guess the number of items to draw on the screen.
By giving an itemExtent, we explicitly say that an item has the following height.
In our case, since all items have the same height, giving this info will help to reduce the number of items in cache.

For that, just try a print() with and without it and you will see a difference, which can sometimes be +/-10 cells.

For the UI, what I propose is to validate your implementation with the screen and I will do some tests to potentially include it in a bottom sheet, but later and in another PR. The idea is not to block this PR.

[monsieurtanuki]

@g123k For the record I will not add itemExtent. I understand the purpose and I have a personal interest in performances, but in general and specifically in that case (user lists) it will add confusion in the code and potentially problem with accessibility, for a non detectable performance improvement.
Especially if you plan to implement another UI later.
Feel free to approve now so that the PR can be merged.

[g123k]

Ok, I let the code as is.
And I work in parallel, to integrate it in a modal sheet.

Thanks for your work @monsieurtanuki!