feat: Improve a11n by forcing a label on Nutri-Score / Eco-score / NOVA buttons #4356
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4356 +/- ##
===========================================
- Coverage 10.34% 10.28% -0.06%
===========================================
Files 293 293
Lines 14636 14746 +110
===========================================
+ Hits 1514 1517 +3
- Misses 13122 13229 +107
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You can test this PR on: https://app.waldo.com/applications/app-19d476740ba1bb36/sessions |
g123k
changed the title
| @@ -2320,5 +2320,24 @@ | |||
| "country_selector_title": "Select your country:", | |||
| "@country_selector_title": { | |||
| "description": "Label written as the title of the dialog to select the user country" | |||
| } | |||
| }, | |||
| "nutriscore_a": "Nutri-Score A", | |||
There was a problem hiding this comment.
We're going to get "Nutri-Skor A" and the likes, which is a pain to maintain translation wise.
There was a problem hiding this comment.
For Nutri-Score, yes maybe…
But for Eco-score, in French we should say Éco-score :/
What would be the best approach?
There was a problem hiding this comment.
The branding for Eco-Score is not completely stabilized. Eco-Score won't hurt, I guess.
There was a problem hiding this comment.
Ok and what about NOVA, where "group" can also be translated?
There was a problem hiding this comment.
For nova, you mean the Ultra-processed foods attributes ? Do you want to concatenate NOVA to it ?
There was a problem hiding this comment.
The idea here is to provide a description that will be read by screen readers.
That's why I've provided a description for Nutriscore/Nova/Ecoscore, because now screen readers won't say anything
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
g123k
force-pushed
the
a11n_nutriscore_ecoscore
branch
from
2a056aa to
2149b5f
Compare
Hi everyone,
On the product page, screen readers will only tell "Good Nutritional Quality", but without saying it's a Nutri-Score B.
This PR implements the feature both for the Nutri-Score and also the Eco-score