-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: User lists picker in a modal sheet #4364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🥫 Product page
Product addition
The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
history
🌐 l10n
labels
Jul 23, 2023
Codecov Report
@@ Coverage Diff @@
## develop #4364 +/- ##
===========================================
- Coverage 10.34% 10.32% -0.03%
===========================================
Files 293 293
Lines 14636 14697 +61
===========================================
+ Hits 1514 1517 +3
- Misses 13122 13180 +58
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You can test this PR on: https://app.waldo.com/applications/app-19d476740ba1bb36/sessions |
Looks 👍 |
teolemon
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bottom sheets
history
🌐 l10n
Product addition
The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
🥫 Product page
User lists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
In the new "Lists" shortcut at the bottom of the screen, we open a new screen when we want to switch between them.
This PR does the same but in a modal sheet.
Here is a video: https://github.com/openfoodfacts/smooth-app/assets/246838/9a34f2e1-8457-45a4-8e7a-db781b687820
This PR also includes several bug fixes with the screen listing products, especially when the list is empty.