Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User lists picker in a modal sheet #4364

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 23, 2023

Hi everyone,

In the new "Lists" shortcut at the bottom of the screen, we open a new screen when we want to switch between them.
This PR does the same but in a modal sheet.

Here is a video: https://github.com/openfoodfacts/smooth-app/assets/246838/9a34f2e1-8457-45a4-8e7a-db781b687820

This PR also includes several bug fixes with the screen listing products, especially when the list is empty.

@g123k g123k self-assigned this Jul 23, 2023
@g123k g123k requested a review from a team as a code owner July 23, 2023 08:02
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. history 🌐 l10n labels Jul 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Merging #4364 (f12d0ff) into develop (ef15cab) will decrease coverage by 0.03%.
The diff coverage is 7.97%.

@@             Coverage Diff             @@
##           develop    #4364      +/-   ##
===========================================
- Coverage    10.34%   10.32%   -0.03%     
===========================================
  Files          293      293              
  Lines        14636    14697      +61     
===========================================
+ Hits          1514     1517       +3     
- Misses       13122    13180      +58     
Impacted Files Coverage Δ
...kages/smooth_app/lib/data_models/product_list.dart 0.00% <0.00%> (ø)
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% <0.00%> (ø)
...b/bottom_sheets/smooth_draggable_bottom_sheet.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/all_product_list_page.dart 0.00% <0.00%> (-2.78%) ⬇️
packages/smooth_app/lib/pages/history_page.dart 10.00% <ø> (ø)
...ib/pages/preferences/user_preferences_widgets.dart 8.49% <0.00%> (+0.05%) ⬆️
...p/lib/pages/product/common/product_list_modal.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)
...app/lib/pages/product_list_user_dialog_helper.dart 0.00% <0.00%> (ø)
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 75.65% <100.00%> (+0.16%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@teolemon
Copy link
Member

Looks 👍

@teolemon teolemon merged commit d00f9a0 into openfoodfacts:develop Jul 24, 2023
@g123k g123k deleted the lists_picker branch July 28, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bottom sheets history 🌐 l10n Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page User lists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants