Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated Crowdin translations #4473

Merged
merged 432 commits into from
Aug 9, 2023
Merged

fix: updated Crowdin translations #4473

merged 432 commits into from
Aug 9, 2023

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Aug 7, 2023

No description provided.

@teolemon teolemon requested a review from a team as a code owner August 7, 2023 10:01
@teolemon teolemon changed the title New Crowdin updates fix: updated Catalan translations Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

You can test this PR on: Android

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #4473 (814db79) into develop (5dfbbd1) will decrease coverage by 0.01%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4473      +/-   ##
===========================================
- Coverage    10.33%   10.32%   -0.01%     
===========================================
  Files          296      296              
  Lines        15284    15293       +9     
===========================================
  Hits          1579     1579              
- Misses       13705    13714       +9     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

"@contributors_label": {
"description": "Button label: Opens a pop up window where all contributors of this app are shown"
},
"contributors_dialog_title": "Contributeurs",
"@contributors_dialog_title": {
"description": "Dialog title: A list of all contributors of this app"
},
"contributors_dialog_entry_description": "Contributor: {name}",
"contributors_dialog_entry_description": "Contributeur: {name}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is missing here

"app_review_negative_modal_text": "Could you take a few seconds to tell us why?",
"app_review_negative_modal_positive_button": "Yes, absolutely!",
"tagline_app_review": "Aimez-vous cette appli ?",
"tagline_app_review_button_positive": "Je l'adore! 😍",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here (space before !)

@@ -2152,7 +2148,7 @@
"@edit_packagings_element_field_recycling": {
"description": "Field label"
},
"edit_packagings_element_hint_recycling": "Saisissez les instructions de recyclage uniquement si elles figurent sur le produit.",
"edit_packagings_element_hint_recycling": "Enter recycling instructions only if they are listed on the product.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange rollback here

"hunger_games_error_label": "Argh! Something went wrong… and we couldn't load the questions.",
"hunger_games_error_retry_button": "Let's retry!"
"hunger_games_error_retry_button": "Réessayons !"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In French, I think we can be more formal, "Réessayons" seems weirder than in English

@teolemon teolemon changed the title fix: updated Catalan translations fix: updated Crowdin translations Aug 9, 2023
@teolemon teolemon merged commit f8385e5 into develop Aug 9, 2023
@teolemon teolemon deleted the l10n_develop branch August 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants