Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing on some products is COMPLETELY broken #4690

Closed
4 tasks done
teolemon opened this issue Oct 4, 2023 · 1 comment · Fixed by #4699
Closed
4 tasks done

Editing on some products is COMPLETELY broken #4690

teolemon opened this issue Oct 4, 2023 · 1 comment · Fixed by #4699
Labels
🐛 bug Something isn't working ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P0

Comments

@teolemon
Copy link
Member

teolemon commented Oct 4, 2023 •
edited
Loading

What

  • Editing on some products is COMPLETELY broken

Related Sentry issues
Beta Give feedback
  1. _TypeError add_basic_details_page.dart in _AddBasicDetailsPageStat #4695
    ✏️ Editing 🎯 P0 🐛 bug 🙀 bug in production
  2. _TypeError nutrition_page_loaded.dart in _NutritionPageLoadedState #4694
    good first issue ✏️ Editing 🎯 P0 🐛 bug 🙀 bug in production
  3. _TypeError: Null check operator used on a null value in _EditNewPackagingsState.build #4693
    good first issue ✏️ Editing 🎯 P0 🐛 bug 🙀 bug in production
  4. _TypeError: Null check operator used on a null value #4692
    good first issue ✏️ Editing 🎯 P0 🐛 bug 🙀 bug in production

Recording

recording-grey-screen-mobile-app.mp4
@teolemon teolemon added the 🐛 bug Something isn't working label Oct 4, 2023
@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P0 labels Oct 4, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon Basically it's just a matter of the brand being null. cf. #4659.

@monsieurtanuki monsieurtanuki linked a pull request Oct 6, 2023 that will close this issue
fix: Exception when product brands are null #4699
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P0
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Exception when product brands are null WildOrangutan/smooth-app
2 participants
@teolemon @monsieurtanuki