feat: 4674 - new UI for main image page; fallback image only for product icon

[monsieurtanuki]

What

• This is the first PR for New feature: create a screen to view all photos from a product #4674.
• Other PRs will follow, that would include adding somehow the "OTHER" pictures.
• The page where the UI changed is accessible from "edit product" page / "pictures".
• Here we do not use fallback pictures anymore - only the picture that matches the specified language, in order to avoid confusion.
• There's one single exception to that new "no fallback" rule: the product thumbnail.

Screenshot

fr	it	en

Impact on soon-to-be-removed carousel:

fr	it

Part of

• New feature: create a screen to view all photos from a product #4674

Impacted files:

• add_new_product_helper.dart: minor refactoring
• add_new_product_page.dart: minor refactoring
• image_field_extension.dart: minor refactoring
• product_cards_helper.dart: removed references to fallback image - now we stick to the specified language; minor refactoring
• product_image_carousel.dart: minor refactoring
• product_image_gallery_view.dart: added a language selector; new UI
• product_image_swipeable_view.dart: added an optional language parameter; simplified the code now relying only on ImageField
• product_image_viewer.dart: minor refactoring
• smooth_list_tile_card.dart: minor refactoring
• smooth_product_image.dart: now we explicitly use the default image if needed

[codecov-commenter]

Codecov Report

Merging #4738 (b4314bb) into develop (2d90250) will decrease coverage by 0.04%.
Report is 12 commits behind head on develop.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #4738      +/-   ##
==========================================
- Coverage     9.90%   9.87%   -0.04%     
==========================================
  Files          310     310              
  Lines        15807   15846      +39     
==========================================
- Hits          1566    1565       -1     
- Misses       14241   14281      +40     

Files	Coverage Δ
...lib/generic_lib/widgets/smooth_list_tile_card.dart	0.00% <ø> (ø)
.../smooth_app/lib/helpers/image_field_extension.dart	0.00% <ø> (ø)
..._app/lib/pages/product/add_new_product_helper.dart	0.00% <ø> (ø)
...th_app/lib/pages/product/add_new_product_page.dart	0.00% <ø> (ø)
...th_app/lib/pages/product/product_image_viewer.dart	0.00% <ø> (ø)
...ib/cards/product_cards/product_image_carousel.dart	0.00% <0.00%> (ø)
.../lib/generic_lib/widgets/smooth_product_image.dart	0.00% <0.00%> (ø)
...ib/pages/product/product_image_swipeable_view.dart	0.00% <0.00%> (ø)
...s/smooth_app/lib/helpers/product_cards_helper.dart	0.00% <0.00%> (ø)
.../lib/pages/product/product_image_gallery_view.dart	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[g123k]

Thanks for your PR @monsieurtanuki :)

Just so I know where your PR stops, in terms of UI:
-> Will you do the accessibility thing?
-> … change the placeholder?
-> Add the title for the section?

[monsieurtanuki]

Thanks for your PR @monsieurtanuki :)

Just so I know where your PR stops, in terms of UI: -> Will you do the accessibility thing? -> … change the placeholder? -> Add the title for the section?

@g123k The PR is "as is".
Let's work in an interative way: after it's merged let's fine-tune the display. There are already significant model changes in this PR. We can focus on UI details in another PR.

[g123k]

Everything looks good to me.
I think that for "Other photos", you will be forced to use a GridView (since you have a variable number of products). And I wonder if it will not be simpler to directly use it for this part

[monsieurtanuki]

Everything looks good to me. I think that for "Other photos", you will be forced to use a GridView (since you have a variable number of products). And I wonder if it will not be simpler to directly use it for this part

Thank you @g123k for your review!
We don't need a GridView, a horizontal ListView.builder is good enough (cf. the carousel).
That said, there are still some details to clarify. But let's comment that on #4674 instead of that merged PR.