Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support light and dark modes for the eye animation #4885

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 8, 2023

Hi everyone,

The eye animation on the search page was only black.
There's now a light/dark theme.

Untitled.mov

@g123k g123k self-assigned this Dec 8, 2023
@g123k g123k requested a review from a team as a code owner December 8, 2023 20:52
@g123k g123k linked an issue Dec 8, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f0c26da) 9.68% compared to head (9da733d) 9.68%.

Files Patch % Lines
...kages/smooth_app/lib/resources/app_animations.dart 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4885      +/-   ##
==========================================
- Coverage     9.68%   9.68%   -0.01%     
==========================================
  Files          318     318              
  Lines        16113   16123      +10     
==========================================
  Hits          1561    1561              
- Misses       14552   14562      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 05a1328 into openfoodfacts:develop Dec 8, 2023
6 checks passed
@teolemon
Copy link
Member

teolemon commented Dec 8, 2023

thank you @g123k 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The search 'eye' animation is not available in dark mode
4 participants