Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 4923 - added a padding for banner #4927

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix: 4923 - added a padding for banner #4927

merged 1 commit into from
Dec 27, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added a lousy padding so that the banner doesn't hide the last item of the product page's list view.

Screenshot

before after
Screenshot_1703519139 Screenshot_1703519094

Fixes bug(s)

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner December 25, 2023 15:54
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. labels Dec 25, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2554848) 9.66% compared to head (c883166) 9.66%.

Files Patch % Lines
...smooth_app/lib/pages/product/new_product_page.dart 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           develop   #4927      +/-   ##
==========================================
- Coverage     9.66%   9.66%   -0.01%     
==========================================
  Files          323     323              
  Lines        16174   16176       +2     
==========================================
  Hits          1563    1563              
- Misses       14611   14613       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

M123-dev
M123-dev approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@monsieurtanuki monsieurtanuki merged commit b6f97cd into openfoodfacts:develop Dec 27, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your review!

@github-actions github-actions bot mentioned this pull request Dec 27, 2023
Merged
@g123k g123k mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The bottom of the product page needs a little padding
3 participants
@monsieurtanuki @codecov-commenter @M123-dev