Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add hunger game analytics event and track it #5004

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

AshAman999
Copy link
Member

What

Track the hunger game section opening clicks.

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner January 22, 2024 17:24
@github-actions github-actions bot added the 📈 Analytics We use Sentry and Matomo, with an opt-in system label Jan 22, 2024
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshAman999!
LGTM, except an await that you forgot.
Please fix it and I'll approve your PR.

…tribute.dart

Co-authored-by: monsieurtanuki <fabrice_fontaine@hotmail.com>
@AshAman999
Copy link
Member Author

@monsieurtanuki ,

I think its good to go now !

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9f5b6cd) 9.61% compared to head (df7d24b) 9.61%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...pages/preferences/user_preferences_contribute.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5004      +/-   ##
==========================================
- Coverage     9.61%   9.61%   -0.01%     
==========================================
  Files          323     323              
  Lines        16286   16288       +2     
==========================================
  Hits          1566    1566              
- Misses       14720   14722       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AshAman999!

@monsieurtanuki monsieurtanuki merged commit 0ea1967 into openfoodfacts:develop Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track Hunger Games usage in Matomo
3 participants