feat: 5005 - "obsolete product" matomo event #5042
Merged
+35
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `analytics_helper.dart`: added an "obsolete product" matomo event * `barcode_product_query.dart`: sent an "obsolete product" matomo event when relevant * `product_query.dart`: added the new OBSOLETE product field to the fields we retrieve * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded to openfoodfacts 3.4.0
github-actions
bot
added
📈 Analytics
teolemon
approved these changes
Feb 8, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5042 +/- ##
==========================================
- Coverage 9.54% 9.54% -0.01%
==========================================
Files 325 323 -2
Lines 16411 16421 +10
==========================================
Hits 1567 1567
- Misses 14844 14854 +10 ☔ View full report in Codecov by Sentry. |
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Impacted files
analytics_helper.dart: added an "obsolete product" matomo eventbarcode_product_query.dart: sent an "obsolete product" matomo event when relevantproduct_query.dart: added the new OBSOLETE product field to the fields we retrievepubspec.lock: wtfpubspec.yaml: upgraded to openfoodfacts 3.4.0