-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5201 - change currency with country when relevant #5238
feat: 5201 - change currency with country when relevant #5238
Conversation
Impacted files: * `app_en.arb`: message for a "change currency too?" dialog * `country_selector.dart`: new method to change the currency at the same time as the country if relevant * `product_query.dart`: init currency if null * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded `openfoodfacts` to `3.8.0` * `user_preferences_country_selector.dart`: asking to change the currency at the same time as the country only if confirmed or relevant * `welcome_page.dart`: explicitly asking to change the currency at the same time as the country
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5238 +/- ##
==========================================
- Coverage 9.54% 8.62% -0.93%
==========================================
Files 325 329 +4
Lines 16411 16709 +298
==========================================
- Hits 1567 1441 -126
- Misses 14844 15268 +424 ☔ View full report in Codecov by Sentry. |
Can we split into 2 sentences/strings, and avoid ellisions (You've) ? |
I can split into 2 sentences.
I haven't really added anything to the onboarding. It's just that I doesn't seem relevant to display |
@teolemon Done. |
Thank you @teolemon for your review! |
What
We change the currency with the best possible matching value for a given country
Screenshot
Fixes bug(s)
Impacted files
app_en.arb
: message for a "change currency too?" dialogcountry_selector.dart
: new method to change the currency at the same time as the country if relevantproduct_query.dart
: init currency if nullpubspec.lock
: wtfpubspec.yaml
: upgradedopenfoodfacts
to3.8.0
user_preferences_country_selector.dart
: asking to change the currency at the same time as the country only if confirmed or relevantwelcome_page.dart
: explicitly asking to change the currency at the same time as the country