Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5247 - now "unselect"ing for the correct language #5266

Merged
merged 1 commit into from
May 25, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • We passed the correct language to the "unselect" task, but we didn't use this language as "the task" language.
  • As a consequence, we used the default language and unselected the wrong image.
  • Now it's fixed.

Fixes bug(s)

Impacted file

  • background_task_unselect.dart: use of explicit language instead of default language.

Impacted file:
* `background_task_unselect.dart`: use of explicit language instead of default language.
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner May 17, 2024 17:45
@monsieurtanuki monsieurtanuki requested a review from teolemon May 17, 2024 17:45
@monsieurtanuki
Copy link
Contributor Author

@jusdekiwi ping

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.61%. Comparing base (4d9c7fc) to head (45e4d38).
Report is 121 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5266      +/-   ##
==========================================
- Coverage     9.54%   8.61%   -0.94%     
==========================================
  Files          325     329       +4     
  Lines        16411   16736     +325     
==========================================
- Hits          1567    1441     -126     
- Misses       14844   15295     +451     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jusdekiwi
Copy link

@monsieurtanuki brilliant! Looking forward to testing it! Thank you :D

@teolemon teolemon merged commit 8758b0e into openfoodfacts:develop May 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The wrong picture is deleted when deleting a picture in a "not-default" language on the app
4 participants