Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prices images improvement #5301

Closed
monsieurtanuki opened this issue May 28, 2024 · 9 comments · Fixed by #5679
Closed

Prices images improvement #5301

monsieurtanuki opened this issue May 28, 2024 · 9 comments · Fixed by #5679
Assignees
Labels
✨ enhancement New feature or request Prices

Comments

@monsieurtanuki
Copy link
Contributor

We currently have a minimal proof image management for prices ("select an image").

There are several possible improvements:

  1. add the "crop" feature
  2. add the "manually erase/mask personal data in the image" feature
  3. use a specific "always camera/always gallery/always ask" preference for prices - users may have a different typical usage of camera and gallery for product images and price proof images
@monsieurtanuki
Copy link
Contributor Author

Crop feature for price proof:
Screenshot_1716911777

@monsieurtanuki
Copy link
Contributor Author

@teolemon @raphael0202 @raphodn About the eraser, it would like like that:
Screenshot_1717091892

@raphodn
Copy link
Member

raphodn commented May 30, 2024

Nice !

And if you show examples in the app, the cropping shouldn't be too agressive, as we need the location, product prices, and the receipt date 😇

@monsieurtanuki
Copy link
Contributor Author

Thank you @raphodn for your feedback.
We definitely need to display some explanations, with text ("Please check that the location, the date and the prices are visible, and hide the possible personal data like your name or your customer number") and/or with an image.
Different texts/images for receipt and price tags.

@teolemon
Copy link
Member

@monsieurtanuki Can we put the redaction system in black ? The Red breaks my eyes.

@monsieurtanuki
Copy link
Contributor Author

@monsieurtanuki Can we put the redaction system in black ? The Red breaks my eyes.

@teolemon We have full control about the "eraser" feature. Including the color.

@teolemon
Copy link
Member

image
👽

@monsieurtanuki
Copy link
Contributor Author

@teolemon You're right, it's less aggressive in black ;)

@monsieurtanuki
Copy link
Contributor Author

crop mode eraser mode
Screenshot_1717226389 Screenshot_1717226431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request Prices
Development

Successfully merging a pull request may close this issue.

3 participants