Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5323 - generic way to display product images, with timestamp #5333

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now using the same widget to display product image thumbnails.
  • This widget includes the timestamp.

Screenshots

more pictures existing pictures
Screenshot_1717347937 Screenshot_1717347952

Fixes bug(s)

Files

New file:

  • product_image_widget.dart: Displays a product image thumbnail with the upload timestamp on top.

Impacted files:

  • product_image_gallery_other_view.dart: now using new widget ProductImageWidget
  • uploaded_image_gallery.dart: now using new widget ProductImageWidget

New file:
* `product_image_widget.dart`: Displays a product image thumbnail with the upload timestamp on top.

Impacted files:
* `product_image_gallery_other_view.dart`: now using new widget `ProductImageWidget`
* `uploaded_image_gallery.dart`: now using new widget `ProductImageWidget`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 2, 2024 17:15
@monsieurtanuki monsieurtanuki requested a review from teolemon June 2, 2024 17:16
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 7.64%. Comparing base (4d9c7fc) to head (aeb148a).
Report is 159 commits behind head on develop.

Files Patch % Lines
...ooth_app/lib/pages/image/product_image_widget.dart 0.00% 26 Missing ⚠️
...th_app/lib/pages/image/uploaded_image_gallery.dart 0.00% 3 Missing ⚠️
.../pages/image/product_image_gallery_other_view.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5333      +/-   ##
==========================================
- Coverage     9.54%   7.64%   -1.91%     
==========================================
  Files          325     371      +46     
  Lines        16411   18698    +2287     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17268    +2424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@monsieurtanuki monsieurtanuki merged commit c26528c into openfoodfacts:develop Jun 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add timestamps in image picker
3 participants