Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5371 - less ambiguous currency symbol #5376

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • The currency symbol we use for currency edit doesn't give the false impression of forex anymore.

Screenshots

price app
Screenshot_1718429919 Screenshot_1718429855

Fixes bug(s)

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 15, 2024 05:43
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Prices labels Jun 15, 2024
@monsieurtanuki monsieurtanuki requested a review from g123k June 15, 2024 05:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 7.37%. Comparing base (4d9c7fc) to head (802fe76).
Report is 190 commits behind head on develop.

Files Patch % Lines
...th_app/lib/pages/onboarding/currency_selector.dart 0.00% 1 Missing ⚠️
...lib/pages/onboarding/currency_selector_helper.dart 0.00% 1 Missing ⚠️
..._app/lib/pages/prices/price_currency_selector.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5376      +/-   ##
==========================================
- Coverage     9.54%   7.37%   -2.17%     
==========================================
  Files          325     384      +59     
  Lines        16411   19636    +3225     
==========================================
- Hits          1567    1449     -118     
- Misses       14844   18187    +3343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better like this, thanks!

@monsieurtanuki monsieurtanuki merged commit 18505dd into openfoodfacts:develop Jun 15, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Prices
Development

Successfully merging this pull request may close these issues.

Misleading currency icon?
3 participants