-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5526 - new Prices prod/test url flag #5528
feat: 5526 - new Prices prod/test url flag #5528
Conversation
Impacted files: * `background_task_add_prices.dart`: Prices API called using new Prices prod/test url * `get_prices_model.dart`: Prices API called using new Prices prod/test url * `price_user_button.dart`: Prices API called using new Prices prod/test url * `prices_proofs_page.dart`: Prices API called using new Prices prod/test url * `prices_users_page.dart`: Prices API called using new Prices prod/test url * `product_prices_list.dart`: Prices API called using new Prices prod/test url * `product_query.dart`: new Prices prod/test url * `user_preferences_account.dart`: Prices API called using new Prices prod/test url * `user_preferences_dev_mode.dart`: new prod/test flag for Prices url
@monsieurtanuki Can you add an arbitrary URL (so that it can also be used for local development) ? |
@teolemon Not before Monday. |
@teolemon For the record I don't think we can be 100% flexible about the prices url. |
.net .org is nice. |
For the record that's already implemented in this PR: .org for prod and .net for test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monsieurtanuki thank you for the PR. I'll reopen an issue depending on the answer from @raphodn and @raphael0202
Something we should also untangle are calls to Robotoff
Thank you @teolemon for your review! |
What
Screenshot
Fixes bug(s)
Impacted files
background_task_add_prices.dart
: Prices API called using new Prices prod/test urlget_prices_model.dart
: Prices API called using new Prices prod/test urlprice_user_button.dart
: Prices API called using new Prices prod/test urlprices_proofs_page.dart
: Prices API called using new Prices prod/test urlprices_users_page.dart
: Prices API called using new Prices prod/test urlproduct_prices_list.dart
: Prices API called using new Prices prod/test urlproduct_query.dart
: new Prices prod/test urluser_preferences_account.dart
: Prices API called using new Prices prod/test urluser_preferences_dev_mode.dart
: new prod/test flag for Prices url