Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to reorder the action bar #5826

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 9, 2024

Hi everyone!

This PR contains multiple changes:

  • The code for each button of the action bar is now in a dedicated file
  • The default order is changed with "Edit" first, then "Add a price" (is-it ok @teolemon?)
  • We can now reorder and hide items in this bar
  • Flutter doesn't provide a list that animates moves. Hence a dedicated widget.
  • Some minor icon changes
  • The haptic feedback for errors is changed with 3 vibrations and a longer pattern

🎥 Demo: https://github.com/user-attachments/assets/fa7ff19a-54ae-48e3-8bed-494cb07e82d1

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 1.92593% with 662 lines in your changes missing coverage. Please review.

Project coverage is 6.92%. Comparing base (4d9c7fc) to head (b0dee37).
Report is 465 commits behind head on develop.

Files with missing lines Patch % Lines
...oduct_page/footer/new_product_footer_settings.dart 2.10% 279 Missing ⚠️
...kages/smooth_app/lib/widgets/smooth_list_diff.dart 0.00% 121 Missing ⚠️
...roduct/product_page/footer/new_product_footer.dart 1.73% 113 Missing ⚠️
...roduct_page/footer/new_product_footer_compare.dart 2.32% 42 Missing ⚠️
...oth_app/lib/pages/product/product_list_helper.dart 0.00% 17 Missing ⚠️
...duct_page/footer/new_product_footer_add_price.dart 5.55% 17 Missing ⚠️
.../product_page/footer/new_product_footer_share.dart 5.55% 17 Missing ⚠️
...t/product_page/footer/new_product_footer_edit.dart 6.25% 15 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 14 Missing ⚠️
...t_page/footer/new_product_footer_add_to_lists.dart 7.69% 12 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5826      +/-   ##
==========================================
- Coverage     9.54%   6.92%   -2.63%     
==========================================
  Files          325     422      +97     
  Lines        16411   23229    +6818     
==========================================
+ Hits          1567    1609      +42     
- Misses       14844   21620    +6776     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @g123k

@teolemon
Copy link
Member

@g123k merge conflict

@g123k
Copy link
Collaborator Author

g123k commented Nov 10, 2024

@g123k merge conflict

Should be OK now 👌

@teolemon
Copy link
Member

arg, I should have done the crowdin merge last @g123k 🫨

@teolemon
Copy link
Member

Thanks @g123k and sorry for the snafu

@teolemon teolemon merged commit d6446ba into openfoodfacts:develop Nov 11, 2024
6 checks passed
@g123k g123k deleted the reorder_action_bar branch November 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Feature] Allow to reorder the action bar in the product page
3 participants